Not logged in. · Lost password · Register
Forum: agsXMPP RSS
I think the following should be changed ....
Avatar
mayprog #1
Member since Mar 2006 · 61 posts
Group memberships: Members
Show profile · Link to this post
Subject: Stream Initiation and Bytestreams errors found
Working with the latest code from CVN on filetransfers (Stream Initiation and ByteStreams) i have found the following errors ....

These two entries are misisng from ElementFactory constuctor:

AddElementType("feature",Uri.FEATURE_NEG,typeof(agsXMPP.protocol.extensions.featureneg.FeatureNeg));
AddElementType("query",Uri.BYTESTREAMS,typeof(agsXMPP.protocol.extensions.bytestreams.ByteStream));

Also, the Mode property of agsXMPP.protocol.extensions.bytestreams.ByteStream is wrong as it gueries and set a tag althought mode is an atribute in the JEP
so the code from:
        public Mode Mode
        {
           get { return (Mode) GetTagEnum("mode", typeof(Mode)); }
            set
            {
                if (value != Mode.NONE)
                    SetTag("mode", value.ToString());
                else
                    RemoveAttribute("mode");
            }
        }
must become
        public Mode Mode
        {
            get { return (Mode) GetAttributeEnum("mode", typeof(Mode)); }
            set
            {
                if (value != Mode.NONE)
                    SetAttribute("mode", value.ToString());
                else
                    RemoveAttribute("mode");
            }
        }

Hope i am right on these!
Keep on the good work !
Avatar
Alex #2
Member since Feb 2003 · 4317 posts · Location: Germany
Group memberships: Administrators, Members
Show profile · Link to this post
Hello mayprog,

yes you are correct.
but the factory for agsXMPP.protocol.extensions.bytestreams.ByteStream is already there. I fixed the code, but i don't think i will commit before the end of the next week to SVN because im travelling at the moment and wanna check it on my main developer machine before uploading.

Alex
Close Smaller – Larger + Reply to this post:
Verification code: VeriCode Please enter the word from the image into the text field below. (Type the letters only, lower case is okay.)
Smileys: :-) ;-) :-D :-p :blush: :cool: :rolleyes: :huh: :-/ <_< :-( :'( :#: :scared: 8-( :nuts: :-O
Special characters:
Forum: agsXMPP RSS