Stream Initiation and Bytestreams errors found

mayprog

2006-06-07, 20:04 #1

Member since Mar 2006 · 61 posts
Group memberships: Members

Show profile ·

Link to this post

Subject: Stream Initiation and Bytestreams errors found

Working with the latest code from CVN on filetransfers (Stream Initiation and ByteStreams) i have found the following errors ....

These two entries are misisng from ElementFactory constuctor:

AddElementType("feature",Uri.FEATURE_NEG,typeof(agsXMPP.protocol.extensions.featureneg.FeatureNeg));
AddElementType("query",Uri.BYTESTREAMS,typeof(agsXMPP.protocol.extensions.bytestreams.ByteStream));

Also, the Mode property of agsXMPP.protocol.extensions.bytestreams.ByteStream is wrong as it gueries and set a tag althought mode is an atribute in the JEP
so the code from:

public Mode Mode
      {
   get { return (Mode) GetTagEnum("mode", typeof(Mode)); }
      set
      {
      if (value != Mode.NONE)
      SetTag("mode", value.ToString());
      else
      RemoveAttribute("mode");
      }
      }

must become

public Mode Mode
      {
      get { return (Mode) GetAttributeEnum("mode", typeof(Mode)); }
      set
      {
      if (value != Mode.NONE)
      SetAttribute("mode", value.ToString());
      else
      RemoveAttribute("mode");
      }
      }

Hope i am right on these!
Keep on the good work !

Alex

2006-06-07, 20:46 #2

Member since Feb 2003 · 4388 posts · Location: Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

Hello mayprog,

yes you are correct.
but the factory for agsXMPP.protocol.extensions.bytestreams.ByteStream is already there. I fixed the code, but i don't think i will commit before the end of the next week to SVN because im travelling at the moment and wanna check it on my main developer machine before uploading.

Alex