Subject: Stream Initiation and Bytestreams errors found
Working with the latest code from CVN on filetransfers (Stream Initiation and ByteStreams) i have found the following errors ....
These two entries are misisng from ElementFactory constuctor:
Also, the Mode property of agsXMPP.protocol.extensions.bytestreams.ByteStream is wrong as it gueries and set a tag althought mode is an atribute in the JEP
so the code from:
Hope i am right on these!
Keep on the good work !
These two entries are misisng from ElementFactory constuctor:
AddElementType("feature",Uri.FEATURE_NEG,typeof(agsXMPP.protocol.extensions.featureneg.FeatureNeg));
AddElementType("query",Uri.BYTESTREAMS,typeof(agsXMPP.protocol.extensions.bytestreams.ByteStream));
AddElementType("query",Uri.BYTESTREAMS,typeof(agsXMPP.protocol.extensions.bytestreams.ByteStream));
Also, the Mode property of agsXMPP.protocol.extensions.bytestreams.ByteStream is wrong as it gueries and set a tag althought mode is an atribute in the JEP
so the code from:
public Mode Mode
{
get { return (Mode) GetTagEnum("mode", typeof(Mode)); }
set
{
if (value != Mode.NONE)
SetTag("mode", value.ToString());
else
RemoveAttribute("mode");
}
}
must become{
get { return (Mode) GetTagEnum("mode", typeof(Mode)); }
set
{
if (value != Mode.NONE)
SetTag("mode", value.ToString());
else
RemoveAttribute("mode");
}
}
public Mode Mode
{
get { return (Mode) GetAttributeEnum("mode", typeof(Mode)); }
set
{
if (value != Mode.NONE)
SetAttribute("mode", value.ToString());
else
RemoveAttribute("mode");
}
}
{
get { return (Mode) GetAttributeEnum("mode", typeof(Mode)); }
set
{
if (value != Mode.NONE)
SetAttribute("mode", value.ToString());
else
RemoveAttribute("mode");
}
}
Hope i am right on these!
Keep on the good work !