Timing Issue with Setting Subscriptions

ChrisGroh

2017-11-28, 21:16 #1

Member since Nov 2017 · 1 post
Group memberships: Members

Show profile ·

Link to this post

Subject: Timing Issue with Setting Subscriptions

We're using MatriX to connect to Finesse and are experiencing an issue where some users intermittently get an error after logging in. Outside the intermittent error, everything seems to work fine.

The error is:

<error code="400" type="wait" xmlns="jabber:client">
   <unexpected-request xmlns="urn:ietf:params:xml:ns:xmpp-stanzas" />
   <not-subscribed xmlns="http://jabber.org/protocol/pubsub#errors" />
</error>

And occurs if we make a call to PubSubManager.SubscribeAsync or PubSubManager.UnsubscribeAsync in the OnPresence event.

We were able to reproduce the issue with a simplified version of the code in a console app:

static void Main(string[] args)
{
    using (client = new XmppClient())
    {
        client.SetXmppDomain(domain);
        client.SetUsername(agentId);
        client.Password = agentId;
        
        client.OnError += XmppClient_OnError;
        client.OnPresence += Client_OnPresence;
        client.Open();
        
        Console.WriteLine("Listening... Press any key to terminate");
        Console.ReadKey();
        client.Close();
    }
}
 
private static async void Client_OnPresence(object sender, PresenceEventArgs e)
{
    if (isSubscriptionsSet)
        return;
    isSubscriptionsSet = true;
    try
    {
        var mgr = new PubsubSubscriptionManager(client, agentId);
 
        var subNodes = GetNodesToSubscribeTo();
        await mgr.ConfigureInitialSubscriptions(subNodes.ToList());
        Console.WriteLine("Subscriptions set");
    }
    catch (Exception ex)
    {
        Write(ex.ToString());
        Console.WriteLine("Subscriptions set");
    }
}
 
internal class PubsubSubscriptionManager
{
    private readonly PubSubManager psManager;
    private readonly Jid pubsubJid;
    private readonly Jid userJid;
 
    public PubsubSubscriptionManager(XmppClient client, string agentId, ICtiEventLogger log)
    {
        psManager = new PubSubManager(client);
        pubsubJid = new Jid("pubsub." + client.XmppDomain);
        userJid = new Jid(agentId + "@" + client.XmppDomain);
    }
 
    public async Task ConfigureInitialSubscriptions(List<FinesseNodePath> desiredSubscriptions)
    {
        var existingSubscriptions = await GetCurrentSubscriptions();
        var missing = desiredSubscriptions.Except(existingSubscriptions);
        var toRemove = existingSubscriptions.Except(desiredSubscriptions);
 
        foreach (var sub in toRemove)
        {
            var subResult = await psManager.UnsubscribeAsync(pubsubJid, sub.NodeId, userJid);
            if (subResult.Type != IqType.Result)// Error occurs here
            {
                throw new ApplicationException($"Subscription error for '{sub}': {subResult.Error}");
            }
        }
        foreach (var sub in missing)
        {
            var subResult = await psManager.SubscribeAsync(pubsubJid, sub.NodeId, userJid);
            if (subResult.Type != IqType.Result)// Error occurs here
            {
                throw new ApplicationException($"Subscription error for '{sub}': {subResult.Error}");
            }
        }
    }
 
    private async Task<List<FinesseNodePath>> GetCurrentSubscriptions()
    {
        var subResp = await psManager.RequestSubscriptionsAsync(pubsubJid, null);
        if (subResp.Error != null)
            throw new ApplicationException(subResp.Error.ToString());
 
        var pubSubData = subResp.Element<PubSub>();
        var subList = pubSubData.Subscriptions.Elements<Subscription>();
        var result = subList.Select(x => FinesseNodePath.FromPath(x.Node)).ToList();
        return result;
    }
}

This post was edited 5 times, last on 2017-11-28, 21:49 by Alex.

Alex

2017-11-28, 21:34 #2

Member since Feb 2003 · 4449 posts · Location: Germany
Group memberships: Administrators, Members

Show profile ·

Link to this post

it would help when you post your complete Xml log here. So that we can see exactly what you send to your server.