Not logged in. · Lost password · Register
Forum: agsXMPP RSS
Logs
Avatar
Irdis 2013-08-13, 17:07 #1
Member since Sep 2012 · 10 posts
Group memberships: Members
Show profile · Link to this post
Subject: Logs
Hi,
I've been exploring agsXMPP sources for quite some time. I noticed that there are exist number of exception handlers without a body (ordinary example try{\*work hard*\} catch {\*empty*\}). I think it would be great to push such ex to a log. So it will be nice, if you provide an opportunity to set up a custom logger in agsXMPP.
What do you think?
This post was edited on 2013-08-13, 17:22 by Irdis.
Avatar
Irdis 2013-08-13, 17:21 #2
Member since Sep 2012 · 10 posts
Group memberships: Members
Show profile · Link to this post
for example, that looks suspicious from my point of view
  1. try
  2. {
  3.     // first, shutdown the socket
  4.     _socket.Shutdown(SocketShutdown.Both);
  5. }
  6. catch { }
  7.  
  8. try
  9. {
  10.     // next, close the socket which terminates any pending
  11.     // async operations
  12.     _socket.Close();
  13. }
  14. catch { }
This post was edited 2 times, last on 2013-08-13, 17:27 by Alex.
Edit reason: fixed code formatting
Avatar
Alex 2013-08-13, 17:26 #3
Member since Feb 2003 · 4449 posts · Location: Germany
Group memberships: Administrators, Members
Show profile · Link to this post
In reply to post #1
Quote by Irdis:
So it will be nice, if you provide an opportunity to set up a custom logger in agsXMPP.
What do you think?

I don't think this is necessary, but feel free to improve the code and submit patches to us.

Alex
Avatar
Irdis 2013-08-13, 17:27 #4
Member since Sep 2012 · 10 posts
Group memberships: Members
Show profile · Link to this post
gotcha, thx Alex
Close Smaller – Larger + Reply to this post:
Verification code: VeriCode Please enter the word from the image into the text field below. (Type the letters only, lower case is okay.)
Smileys: :-) ;-) :-D :-p :blush: :cool: :rolleyes: :huh: :-/ <_< :-( :'( :#: :scared: 8-( :nuts: :-O
Special characters:

Forum: agsXMPP RSS